DLR-SL / CPACS

CPACS - Common Parametric Aircraft Configuration Schema
http://dlr-sl.github.io/CPACS/
Apache License 2.0
78 stars 38 forks source link

systemArchitectures: specify type of connection #821

Closed MarAlder closed 9 months ago

MarAlder commented 10 months ago

grafik

with transmissionType:

<xsd:restriction base="stringBaseType">
    <xsd:enumeration value="massFlow"/>
    <xsd:enumeration value="heatFlow"/>
    <xsd:enumeration value="electricPower"/>
    <xsd:enumeration value="mechanicalPower"/>
</xsd:restriction>

@jbussemaker, @TimBurschyk

jbussemaker commented 10 months ago

Nice to see this!

Some recommendations:

Some additional connection types off the top of my head:

MarAlder commented 10 months ago
* I would call it `connectionType`, it's a bit more general and maybe "transmission" can be interpreted as something related to gearboxes already

ok, this is fine for me

* Enumeration type is good of course, but I would also allow users to specify their own types (simple as a string)

I am not a friend of this. According to the CPACS philosophy we should try to keep the data model as explicit as possible to enable automated processing. The receiver of the data wants to know what kind of strings he can expect according to the schema.

* I'm not sure if it would make sense to add a unit (kg/s, W, etc.) to the connection node (so as a sibling of `connectionType`), or that this rather makes sense for the analysis results only

Since this is only about the type, I suggest leaving the quantitative values and their units to the powerBreakdown.

TimBurschyk commented 10 months ago

Thanks for adding the type of connection! Here are my thoughts:

jbussemaker commented 10 months ago

The original idea of including connectionType is to distinguish between different types of connections between the same pairs of sources and targets. For example, there could be some physical connection as well as data/signal connection at the same time.

As this might not always be needed for all cases, I would say connectionType can be optional.

MarAlder commented 10 months ago
jbussemaker commented 10 months ago

All right, then I recommend at least the following: