Closed MarAlder closed 9 months ago
Nice to see this!
Some recommendations:
connectionType
, it's a bit more general and maybe "transmission" can be interpreted as something related to gearboxes alreadyconnectionType
), or that this rather makes sense for the analysis results onlySome additional connection types off the top of my head:
* I would call it `connectionType`, it's a bit more general and maybe "transmission" can be interpreted as something related to gearboxes already
ok, this is fine for me
* Enumeration type is good of course, but I would also allow users to specify their own types (simple as a string)
I am not a friend of this. According to the CPACS philosophy we should try to keep the data model as explicit as possible to enable automated processing. The receiver of the data wants to know what kind of strings he can expect according to the schema.
* I'm not sure if it would make sense to add a unit (kg/s, W, etc.) to the connection node (so as a sibling of `connectionType`), or that this rather makes sense for the analysis results only
Since this is only about the type, I suggest leaving the quantitative values and their units to the
powerBreakdown
.
Thanks for adding the type of connection! Here are my thoughts:
connectionType
fits better and follows the proposed structure connections/connection/connectionType
connectionType
optional or should it be? connectionType
, because I think it should be part of the analysis onlyconnectionType
is linked with the types defined in the analysis. The question which pops up is: how specific should the type be? A mass flow can be air, gas, hydraulic oil... do we need to specify this directly and should it be linked to the options within the powerBreakdown
? The original idea of including connectionType
is to distinguish between different types of connections between the same pairs of sources and targets. For example, there could be some physical connection as well as data/signal connection at the same time.
As this might not always be needed for all cases, I would say connectionType
can be optional.
powerBreakdown
. Just provide me a list, which avoids too much redundancy (e.g., signal
could be everything)All right, then I recommend at least the following:
powerBreakdown
hydraulicPower
informationFlow
physicalConnection
with
transmissionType
:@jbussemaker, @TimBurschyk