DLR-SL / CPACS

CPACS - Common Parametric Aircraft Configuration Schema
http://dlr-sl.github.io/CPACS/
Apache License 2.0
78 stars 38 forks source link

energyCarriers: which elements need to ba aligned after renaming the fuel node? #827

Closed MarAlder closed 8 months ago

MarAlder commented 9 months ago

With CPACS v3.5 the fuel node will be renamed to energyCarriers: grafik

CPACS users have requested that other nodes referring to fuel be adapted to this new terminology. I would like to get feedback on which nodes need to be renamed accordingly for CPACS v3.5.

Before we start changing some crucial CPACS nodes I want to throw some thoughts into the room:

So, here some classical fuel elements in CPACS:

So do we need to rename (some of) these nodes? Or is fuel' still an appropriate term to refer tochemicalEnergyCarriers'? What should be the correct terminology in aircraft design?

@DanielSilberhorn, @TimBurschyk, @marcengelmann, ...

marcengelmann commented 9 months ago

Hi Marko, we discussed the topic internally and in general we are ok with staying with the name fuel for all the nodes. We have some small discussion points however: 1) Regarding the split in energy carriers between fuels and electrical energy carriers, we were unsure how the two node types would differ. Depending on what the outcome of this is, we could also imagine something in the style of this:

<energyCarriers>
        <energyCarrier xsi:type="variableMassEnergyCarrierType">
            ...
        </energyCarrier>
        <energyCarrier xsi:type="constantMassEnergyCarrierType">
            ...
        </energyCarrier>
</energyCarriers>

At BHL we use this differentiation with xsi:type quite extensively, but there is also another way to implement this.

2) We did this distinguishment in order have another suggestion for the flight points:

    <flightPoints>
        <energyFlows>
            <energyFlow storedEnergyCarrier="kerosene">
                <value>1;1;</value>
                <massFlow>2;2;</massFlow> <!-- OPTIONAL -->
            </energyFlow>
        </energyFlows>
    </flightPoints>

Because there we would be able to integrate the the energy flows and mass flows into one list. In general we like the idea to have not hardcoded kerosene flow but rather a list of flows.

3) In the fuelsInTank / fuelInTank, is it intentaional that the lowest node does not have a mass description but is of generic mass type itself? Would that not be inconsistent?

Please just see this as a suggestion from our side to highlight what we would like to see adapted in order to dynamically cover mutliple cases. We are looking forward to discuss this of course and also would like to hear other opinions.

MarAlder commented 9 months ago

Thanks for the detailed feedback @marcengelmann. Point 3 is a bug in the implementation, I'll fix it, thanks! We'll get back to you on the other two points.

MarAlder commented 8 months ago

Sorry for the late reply. We also sat together and thought about your suggestions. Personally, I like the technical solution in point 1 of assigning different types to the element and thus specifying what kind of energyCarrier it is. However, this is more in line with our previous proposal, which led to the inconsistent naming of energyCarrier/fuel and thus to this issue. Also, I'm afraid we should not confront the CPACS community with this kind of implementation, as it adds complexity and it is hard enough to use CPACS without appropriate libraries. Therefore, I would like to assign different complex types only via explicit element names.

The second point is of course nicely consistent with the first. However, attributes should rather be used for metadata (e.g. uIDs) in CPACS. Our suggestion is to explicitly link fuels via the configurationDefinitions to specify which energy carriers are used for the aircraft model.

We propose to leave the electrical energy carriers out of v3.5 for now and work together with you on this. Accordingly, we would keep the name fuels for stuff like kerosene or SAF in the future, so that we remain consistent in naming throughout CPACS.

I hope this is acceptable from BHL's point of view. We will get back to you in the new year regarding electrical energy sources.

marcengelmann commented 8 months ago

Hi Marko, it is ok for us to go with the way you propose for now. Of course we would appreciate to be part of any future discussions regarding this topic.

MarAlder commented 8 months ago

fine :)