Closed sjoelund closed 10 years ago
I guess it conflicts with #23.
I guess so too. This one keeps using 32-bit integers. But it's mostly the same changes I suppose.
Yes, #23 compiles fine under Linux
[iti@vm-centos-x64-1 Noise]$ gcc --version
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-54)
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
[iti@vm-centos-x64-1 Noise]$ gcc -c -Wall -std=c89 ModelicaNoise.c
[iti@vm-centos-x64-1 Noise]$
You might test #23 and withdraw this pull request.
I would if I had a machine where int was not 32-bit. The code in #23 will not work the same on all platforms.
I see. Even more issues:
Check ModelicaMatIO.h:
/* uint32 type */
#define _mat_uint32_t unsigned
I guess you want to change this as well and use stdint types instead.
Of course :)
Mo ticket please. Patch would even be better.
@sjoelund, @tbeu: We are not sure, which patch to pull and if there are still issues, which you would like to fix first. Could you clarify or propose a joint patch?
Sure, we are working on it.
Also removes unused code according to compiler warnings