Missing MODELICA_EXPORT or move functions?

DLR-SR / Noise

Modelica library for generating stochastic signals to be included in the Modelica Standard Library

9 stars 11 forks source link

Missing MODELICA_EXPORT or move functions? #63

Closed tbeu closed 9 years ago

tbeu commented 9 years ago

In ModelicaRandom.c the functions

ModelicaRandom_getpid
ModelicaRandom_getTime
ModelicaRandom_hashString

must change from static to MODELICA_EXPORT since they are used by external functions.

I can prepare PR if you like.

@MartinOtter @HansOlsson Otherwise it needs to be discussed if getpid and getTime should be moved to ModelicaInternal.c and hashString to ModelicaStrings.c, respectively. If yes, this can be already done by now in MSL 3.2.2 trunk dev.

MartinOtter commented 9 years ago

Yes, ModelicaRandom_xxx C functions should be moved to MSL 3.2.2 trunk (ModelicaInternal.c and ModelicaStrings.c. Please, do it.

tbeu commented 9 years ago

OK, will do it later for these 3 functions.

tbeu commented 9 years ago

Fixed by r8527 in MSL SVN trunk, see svn2github/Modelica_StandardLibrary@61763832d4c6ce46403919c11a5cd5ff396d6735

tbeu commented 9 years ago

BTW, getpid and getTime needed to be adapted to be compatible to more platforms.

akloeckner commented 9 years ago

Thank you!