search

DLR-SR / Noise

Modelica library for generating stochastic signals to be included in the Modelica Standard Library
9 stars 11 forks source link

Add license info to ModelicaNoise.c #9

Closed tbeu closed 9 years ago

tbeu commented 10 years ago

ModelicaNoise.c probably should be licensed under Modelica License 2. Please add some license comment to it. See ModelicaInternal.c for some idea.

sjoelund commented 10 years ago

It's a bad idea to license C-code under the Modelica license. The reason is that the license is Modelica-specific (you are only allowed to modify and use the code if you move it to another Modelica package)... The license on the ModelicaStandardTables.c is better.

tbeu commented 10 years ago

That's a general issue that always confuses me, see e.g. modelica/Modelica_DeviceDrivers#35. Also MSL C sources like ModelicaInternal.c, ModelicaStrings.c etc. use MoLic2. Maybe some license experts can help? @dietmarw @MartinOtter ?

sjoelund commented 10 years ago

Well, the way I read the license is, if you use the ModelicaInternal.c in your own project, you should rename it MyInternal.c and change the interface of the functions from e.g. ModelicaInternal_getenv to MyInternal_getenv. It would be good if the license was changed also in MSL...

akloeckner commented 9 years ago

@MartinOtter: Is this fixed with https://github.com/DLR-SR/Noise/commit/3cb8c8f2e78905b718340cd9cfa0f719dd72c912#diff-b6a3f43c37c0fa48a520c8b44738f03e ?

tbeu commented 9 years ago

No, it's not considered yet. ModelicaRandom.c still claims to be licensed under MoLic2. This is not appropriate.

fvanderlinden commented 9 years ago

Could someone look if this now is OK with #57?