search

DLTcollab / TA-endpoint

Connect resource constrained endpoints with Tangle-Accelerator
Apache License 2.0
0 stars 2 forks source link

feat: Encapsulate hardware-specific operations #30

Closed splasky closed 4 years ago

splasky commented 4 years ago

These commit did the following things:

  1. Add abstraction layer to support different hardware like get_key and get_device_id.
  2. Rebase onto current develop branch.
  3. Update return type inside conn_http.c functions.
jserv commented 4 years ago

Change hardware_deps to hal, which means hardware abstraction layer.

jserv commented 4 years ago

Let's re-organize the directory structure:

  1. Directory hal: generic code and interface; We need documentation though.
  2. Directory devices/sierra_wireless/wp7702: The exact hardware-specific implementation;
jserv commented 4 years ago

The policy is "every pull request is used to close existing issue(s)."

jserv commented 4 years ago

Don't write git commit messages starting with "Draft."

jserv commented 4 years ago

Let's split "emulator" device support out of this pull request, which eases the effort of reviewing.

jserv commented 4 years ago

Expected procedure for HAL related changes:

  1. Proposed common interface for HAL;
  2. Re-implement WP7702 specific support with HAL;
  3. Write down brief documentation about HAL;
  4. (in another pull request) Provide "emulator" or "simulator" device with HAL;

Ask @HowJMay for mentoring.

splasky commented 4 years ago

This pull request is too messy and cannot clearly express subject. I will close this pull request and split commits for more easily for reviewing.