search

DLTcollab / TA-endpoint

Connect resource constrained endpoints with Tangle-Accelerator
Apache License 2.0
0 stars 2 forks source link

feat: Promote send-via-https as generic utility #40

Closed splasky closed 4 years ago

splasky commented 4 years ago

Defining send_http_msg() inside main.c may cause us hard to intergrate with legato or implement unit-test. A new file url.h is added, it includes HTTPS protocol implementation.

Change send_http_msg() prototype for sending general message instead of restricting format.

Closes #49

jserv commented 4 years ago

Since the function prototype of send_http_msg was changed, the subject is no longer accurate. Rework!

jserv commented 4 years ago

Don't abuse "Refactor." Please do look up dictionary and improve the subject. You can use more words though.

jserv commented 4 years ago

Check Google's Engineering Practices documentation for understanding fundamental concepts.

jserv commented 4 years ago

Mention the issue number that pull request is going to close.

jserv commented 4 years ago

It does not make sense for the following message

Move send_http_msg() under utils for reuse for other devices.

Reasons:

  1. Lack of the descriptions about example devices;
  2. Fix grammar;
  3. No information on send_http_msg.
jserv commented 4 years ago

Fix the grammar again in PR.

jserv commented 4 years ago

The subject is misleading. Indeed, it is a matter of https-oriented sender routine.

jserv commented 4 years ago

Avoid using "Modify" in the subject unless you just perform unwanted changes.