search

DLTcollab / TA-endpoint

Connect resource constrained endpoints with Tangle-Accelerator
Apache License 2.0
0 stars 2 forks source link

Eliminate compilation warnings #52

Closed splasky closed 4 years ago

splasky commented 4 years ago

gcc-9 shows a harmless warning from conn_http:

connectivity/conn_http.c:118:68: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
  118 | retcode_t http_send_request(connect_info_t *const info, const char const *req) {
      |                                                                                                                                                   ^~~~~

Remove one of the specifiers give as the expectd behavior.

Fix const qualifier warning and pointer signedness warning from test_crypto_utils and main function. Inside test_crypto_utils.c we define text test data as constant char* type, we should unify them.

Closes #51

jserv commented 4 years ago

Fix grammar:

It is forbidden to assign read-only variables, remove redundant const specifier.

You need to explain the rationale between the two sentences.

jserv commented 4 years ago

There should be only one git commit. Squash and rework.