search

DLTcollab / TA-endpoint

Connect resource constrained endpoints with Tangle-Accelerator
Apache License 2.0
0 stars 2 forks source link

Modify argument order #54

Closed splasky closed 4 years ago

splasky commented 4 years ago

Don't put a input parameter after a output parameter. The order will mislead people. example from utils/crypto_utils.h

 * @param[in] keybits Length of key
 * @param[in, out] iv[AES_BLOCK_SIZE] Initialization vector
 * @param[out] ciphertext Ciphertext
 * @param[in] ciphertext_len Ciphertext length
int aes_encrypt(const char *plaintext, int plaintext_len, const unsigned char *key, unsigned int keybits, unsigned char iv[AES_BLOCK_SIZE], char *ciphertext, int ciphertext_len);
splasky commented 4 years ago

Has been merged into feat(endpoint): Consolidate by merging Endpoint subproject #570.