DLTcollab / dcurl

Hardware-accelerated Multi-threaded IOTA PoW, drop-in replacement for ccurl
MIT License
41 stars 23 forks source link

Fix: Revise the behavior under multiple PoW requests #229

Closed Fangop closed 4 years ago

Fangop commented 4 years ago

Multiple PoW requests

The original C-GO interface will lead to errors under multiple PoW requests. The 2 reasons are below:

fix(C-GO): Remove redundat initializations

This commit fixed:

fix(C-GO): Align return trytes with length 2673

This commit fixed:

feat(C-GO): Add mutiple PoW request test

This commit provide:

marktwtn commented 4 years ago

Where are the corresponding initialization and destroy functions in cgo/pow/pow_test.go?

marktwtn commented 4 years ago

Fix commit message: Here is a test which simulates mutiple PoW request. mutiple -> multiple

Fangop commented 4 years ago

Fix commit message: Here is a test which simulates mutiple PoW request. mutiple -> multiple

Resolved

marktwtn commented 4 years ago

Fix commit message: Remove redundat initializations -> Remove redundant initializations Add multiple PoW request, simulates multiple PoW request -> PoW requests

Fangop commented 4 years ago

Fix commit message: Remove redundat initializations -> Remove redundant initializations Add multiple PoW request, simulates multiple PoW request -> PoW requests

Resolved?

Fangop commented 4 years ago

Rename the commit header feat(C-GO): Add multiple PoW requests test -> test(C-GO): Add multiple PoW requests test

Resolved. Also, I added DcurlDestroy at the last of pow package test.