Closed Fangop closed 4 years ago
Where are the corresponding initialization and destroy functions in cgo/pow/pow_test.go
?
Fix commit message:
Here is a test which simulates mutiple PoW request.
mutiple -> multiple
Fix commit message:
Here is a test which simulates mutiple PoW request.
mutiple -> multiple
Resolved
Fix commit message:
Remove redundat
initializations -> Remove redundant
initializations
Add multiple PoW request
, simulates multiple PoW request
-> PoW requests
Fix commit message: Remove
redundat
initializations -> Removeredundant
initializations Add multiple PoWrequest
, simulates multiple PoWrequest
-> PoWrequests
Resolved?
Rename the commit header
feat(C-GO): Add multiple PoW requests test
->test(C-GO): Add multiple PoW requests test
Resolved. Also, I added DcurlDestroy at the last of pow package test.
gofmt
Multiple PoW requests
The original C-GO interface will lead to errors under multiple PoW requests. The 2 reasons are below:
fix(C-GO): Remove redundat initializations
This commit fixed:
init
. Added an api for destroy dcurlfix(C-GO): Align return trytes with length 2673
This commit fixed:
init_trytes
to make sure the length is 2673. However, usinginit_trytres
may leads to memory leak in GO. Hence I use a length constraint for fixing this, as the implementation ofinit_trytres
using memcpy.feat(C-GO): Add mutiple PoW request test
This commit provide:
nonce
under multiple requests.