search

DLvalentine / eslint-rails-ee

Fork of https://github.com/appfolio/eslint-rails with new features and continued support
https://rubygems.org/gems/eslint-rails-ee
MIT License
3 stars 4 forks source link

Clarify therubyracer dependency #4

Open DLvalentine opened 6 years ago

DLvalentine commented 6 years ago

It isn't just a dev dependency, it is also a runtime dependency

jamesbebbington commented 4 years ago

Hey @DLvalentine does it need to be? Development on the therubyracer has stalled, and Rails 6 now specifies mini_racer instead.

Seeing as execjs "automatically picks the best runtime available", I think removing the dependency on therubyracer and letting execjs handle it, both simplifies matters and makes it more flexible.