DMAGmbH / dma_elementgenerator

DMA Elementgenerator (Contao)
45 stars 17 forks source link

PHP 7 compatibility #99

Closed fritzmg closed 7 years ago

fritzmg commented 8 years ago

There are several instances where dma_elementgenerator uses the old \String class, which is deprecated in Contao >= 3.5.1 and incompatible with PHP 7. In order to make this extension compatible with PHP 7, it needs to replace all usages of the \String class with \StringUtil (but only for Contao 3.5.1 and up).

cgpro commented 8 years ago

This happens for example in DMAElementGeneratorCallbacks.php

Easy fix: replace \String with \StringUtil (until the changes are available via composer)

JanoschSkuplik commented 8 years ago

It's already fixed in the develop-branch. With a lot of more optimizations.

cgpro commented 8 years ago

Ah ok, pls close it! :)