search

DMDcoin / diamond-contracts-claiming

claiming contracts
0 stars 2 forks source link

Signatures with 33 byte size of R or S are not supported (starting with H) #21

Closed SurfingNerd closed 4 months ago

SurfingNerd commented 7 months ago

It is very clear now that the DMD v3 signing tool diamond-cli signmessage is able to create Signatures that have a 33 byte length of it's R or maybe even S component. The EVM has a native support for 32 byte, and those 33 byte values are causing troubles there.

Because of this technical limitation we are currently only accepting signatures with R and S values equal to 32 bytes.

First tests show, that about 50% of signatures made with DMDv3 are affected. luckily those can be identified by the first letter of the signature. Signatures starting with I are known to work, while signatures starting with H cannot be supported.

SurfingNerd commented 4 months ago

cloising: we went for the strategy to provide a postfix to the claiming message, so users can create a valid transaction for each pair account by adding postfixes.