DMDcoin / diamond-contracts-core

DMD v4 testnet on-chain logic
Other
6 stars 9 forks source link

Integration of Audit Tools. #153

Open SurfingNerd opened 1 year ago

SurfingNerd commented 1 year ago

Slither

Mythril

The first Mythril report took more than 16 hours to generate - looks like it is not possible to integrate them as github tasks, but it's good to have preaudit.

Solhint

was already part of our development.

SurfingNerd commented 1 year ago

slither_report.txt

SurfingNerd commented 1 year ago

mythril_results.zip slither-report.zip

SurfingNerd commented 1 year ago

dummy code for spawning

  import * as child from 'child_process';
  const solidityFile = "Some.sol";
  const promise = child.spawn('mythril', [solidityFile]);
  // promise has several .on(...) events where you can listen to data.
axel-muller commented 5 months ago

Securify2 repo looks abandoned (last commit 3 years ago). It's not possible to build docker image and use it for solidity version we are targeting in contracts (>=0.8.17). List of Securify2 supported vulnerabilities almost fully covered by combination of static analysis tools we already using - solhint, slither, mythril. So usage of Securify2 looks pretty useless and redundant.

SurfingNerd commented 1 month ago

removed sourcify2 from list of tools we should include