search

DMDcoin / diamond-node

bit.diamonds node software for network version 4
GNU General Public License v3.0
0 stars 3 forks source link

occasionally wrong version info. #75

Closed SurfingNerd closed 8 months ago

SurfingNerd commented 8 months ago

The binary version sometimes does not always match the version of diamond-node.

I think the reason behind it is the util/version crate in incremental builds, because the rust cargo does not rebuild the crate if there is no change in the version info gets fetched during the build.

SurfingNerd commented 8 months ago

cargos change detection does not detect the change, because the version info is coming from vergen. there are some possibilities to define a rebuild reason in a cargo build script cargo:rerun-if-... , but none of them solves our issue here.

https://doc.rust-lang.org/cargo/reference/build-scripts.html#change-detection

SurfingNerd commented 8 months ago

closing: can only be solved outside the project, by adding rm commands within the script to always ensure that the version crates gets rebuild