search

DMDcoin / diamond-node

bit.diamonds node software for network version 4
GNU General Public License v3.0
0 stars 3 forks source link

Migrate "threshold-crypto" crate from "failure" to "thiserror" #95

Closed dforsten closed 2 months ago

dforsten commented 5 months ago

Critical issue reported by dependabot.

dforsten commented 5 months ago

Already fixed with the newest commit on the "threshold-crypto" repo, but it is not labeled as a new version. The "hbbft" crate needs to be patched to use that newest commit instead.

dforsten commented 5 months ago

The "fedmint" project maintains private forks of hbbft/threshold-crypto as well, we may want to do the same: https://github.com/fedimint

dforsten commented 5 months ago

I implemented the necessary changes, creating a PR to the poanetwork/hbbft repo. In the meantime the changes are available on my private fork at: https://github.com/dforsten/hbbft

dforsten commented 5 months ago

PR for the poanetwork hbbft repo submitted here: https://github.com/poanetwork/hbbft/pull/441

SurfingNerd commented 2 months ago

solved: there is no critical issue anymore