DMOJ / online-judge

A modern open-source online judge and contest platform system.
https://dmoj.ca
GNU Affero General Public License v3.0
951 stars 364 forks source link

New settings for disable comments and social #2304

Closed FherStk closed 9 months ago

FherStk commented 10 months ago

Related with: https://github.com/DMOJ/online-judge/pull/2298

Added new settings to disable social and comments sections (false by default): image

Blog post example with social and comments enabled (by default): image

Blog post example with social and comments disabled: image

codecov-commenter commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (86c234f) 46.78% compared to head (09dc460) 46.76%.

Files Patch % Lines
judge/views/blog.py 0.00% 2 Missing :warning:
judge/views/contests.py 0.00% 2 Missing :warning:
judge/views/problem.py 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2304 +/- ## ========================================== - Coverage 46.78% 46.76% -0.02% ========================================== Files 251 251 Lines 13309 13317 +8 ========================================== + Hits 6226 6228 +2 - Misses 7083 7089 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

FherStk commented 10 months ago

Otherwise LGTM -- could you please rebase and squash your commits? Then we can go ahead and merge this.

I'm not used to squash and rebase, but I hope I squashed it correctly :)

Xyene commented 10 months ago

Not quite :)

You want to run git rebase -i HEAD~10, which will bring up interactive rebase for the last 10 commits, and change the last few lines to

...
pick 47863906 new settings options for disabling comments and social
s eec0b6a9 new settings options for disabling comments and social
s a528dd54 disable-{social | comments} --> enable-{social | comments}
s 9f2f5fa5 Fixes for 2304#d

s short for 'squash', see the big comment in interactive rebase for details. Then you'll be prompted to fix up the commit text for the commit things are being squashed into (47863906), after which you'll be able to --force push the result onto your branch.

FherStk commented 9 months ago

Not quite :)

You want to run git rebase -i HEAD~10, which will bring up interactive rebase for the last 10 commits, and change the last few lines to

...
pick 47863906 new settings options for disabling comments and social
s eec0b6a9 new settings options for disabling comments and social
s a528dd54 disable-{social | comments} --> enable-{social | comments}
s 9f2f5fa5 Fixes for 2304#d

s short for 'squash', see the big comment in interactive rebase for details. Then you'll be prompted to fix up the commit text for the commit things are being squashed into (47863906), after which you'll be able to --force push the result onto your branch.

Hi,

Sorry for the delay, I've been a little overwhelmed with my work, but I hope I squashed correctly now. I'm very grateful for all your help and support.

Thanks again! Fher