Closed FherStk closed 9 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
86c234f
) 46.78% compared to head (09dc460
) 46.76%.
Files | Patch % | Lines |
---|---|---|
judge/views/blog.py | 0.00% | 2 Missing :warning: |
judge/views/contests.py | 0.00% | 2 Missing :warning: |
judge/views/problem.py | 0.00% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Otherwise LGTM -- could you please rebase and squash your commits? Then we can go ahead and merge this.
I'm not used to squash and rebase, but I hope I squashed it correctly :)
Not quite :)
You want to run git rebase -i HEAD~10
, which will bring up interactive rebase for the last 10 commits, and change the last few lines to
...
pick 47863906 new settings options for disabling comments and social
s eec0b6a9 new settings options for disabling comments and social
s a528dd54 disable-{social | comments} --> enable-{social | comments}
s 9f2f5fa5 Fixes for 2304#d
s
short for 'squash', see the big comment in interactive rebase for details. Then you'll be prompted to fix up the commit text for the commit things are being squashed into (47863906
), after which you'll be able to --force
push the result onto your branch.
Not quite :)
You want to run
git rebase -i HEAD~10
, which will bring up interactive rebase for the last 10 commits, and change the last few lines to... pick 47863906 new settings options for disabling comments and social s eec0b6a9 new settings options for disabling comments and social s a528dd54 disable-{social | comments} --> enable-{social | comments} s 9f2f5fa5 Fixes for 2304#d
s
short for 'squash', see the big comment in interactive rebase for details. Then you'll be prompted to fix up the commit text for the commit things are being squashed into (47863906
), after which you'll be able to--force
push the result onto your branch.
Hi,
Sorry for the delay, I've been a little overwhelmed with my work, but I hope I squashed correctly now. I'm very grateful for all your help and support.
Thanks again! Fher
Related with: https://github.com/DMOJ/online-judge/pull/2298
Added new settings to disable social and comments sections (false by default):
Blog post example with social and comments enabled (by default):
Blog post example with social and comments disabled: