search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 109 forks source link

Move 'Your institution' button below email/pwd fields on sign in form #1028

Closed briri closed 6 years ago

briri commented 6 years ago

Make the 'Your Institution' button less prominent on the sign-in form. Move it so that it is below the email and password section.

briri commented 6 years ago

@sjDCC and @dsisu here is a screenshot of the revised sign in form. Let me know if this will work for DCC or if we should make any further adjustments. The code is currently in review but should be deployed and ready for testing on Friday. screen shot 2018-01-10 at 9 27 31 am

sjDCC commented 6 years ago

That looks great! Thanks @briri

Seeing this screengrab reminds me of the other css refinements ticket #867. I'd asked for the coloured background to stop at the end of the buttons so they look more like tabs.

I can't see this scheduled/assigned in the gannt chart but it will be an important one for user recognition / adoption. Is this something we can prioritise @stephaniesimms

briri commented 6 years ago

I think we should review that ticket. We'll each be doing some work to brand the shared codebase for our respective tools, so I would like to determine which requests should be handled at the shared code level versus in our own branding customizations. (e.g. button alignment seems to be something useful for all, but maybe others are not) We can prioritize the resulting list of tasks.

sjDCC commented 6 years ago

Ok, perhaps @stephaniesimms and I can review it then? I'd assume she was ok with them all since she copied them into a new ticket.

I'd like to keep as much as possible in the common code base so that looks polished too and limit local branding to colours etc. The things I suggested here were not DMPonline specific, rather general button placement, layout and looks and feel improvements.

sjDCC commented 6 years ago

The change on the sign in area looks good so closing this ticket out.

@stephaniesimms and I have liaised on the CSS and @jollopre will make changes in #867