DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 109 forks source link

Create Super Admin page to manage Orgs #1056

Closed stephaniesimms closed 6 years ago

stephaniesimms commented 6 years ago

Add a page "Organizations" in the Admin menu for users with Super Admin privileges (screenshot 1). Super Admins need to be able to see a complete list of Orgs, create new Orgs, and manage basic info. When a user clicks the "Create Organization" button they should be taken to the Org details page (screenshot 2) where they can add/save a new Org.

This same Org details page can then be edited by users from that org w/Org Admin privileges. But the Org Configuration details (Shib) section at the bottom will be grayed out and read only for Org Admins (only Super Admins can edit this info).

Make sure to implement same pagination and search box logic if the list exceeds 10 records #1055

Two notes though based on how it currently works in DMPonline:

  1. The org type should display textual categories (i.e. 'funder' 'institution') to select from. Currently we just have codes for each 0, 1 etc
  2. The only mandatory field on creating an org should be 'name'. Previously you were forced to enter a contact email to save changes but this may have been removed now.

1 - Organizations page screen shot 2018-01-17 at 7 19 59 am

2 - Org details page screen shot 2018-01-17 at 7 26 10 am

stephaniesimms commented 6 years ago

looking good @briri - some things i noticed while testing that need attention:

stephaniesimms commented 6 years ago

mostly working as expected now @briri - a few things that need attention:

screen shot 2018-02-01 at 9 22 55 am

briri commented 6 years ago

I'm reluctant to add asterisks for required fields to this specific page since we're not doing that elsewhere. Is this something we want to have for any required field across the site?

stephaniesimms commented 6 years ago

yes it is and i though we had implemented it ... apologies if i haven't noticed the omission elsewhere. ok hold off for now and we can make a decision to do a global implementation of asterisks later. i updated the bullets above.

sjDCC commented 6 years ago

Hi @briri I'm getting the same error page as Steph above, but have realised this is specific to Edinburgh (not related to your affiliation) so it must be down to bad data. I can edit other orgs fine, and changed my affiliation to Glasgow and that also worked.

The search is working but sort/filter of the org name doesn't have any effect as @stephaniesimms noted. And if you 'view all' and then filter it jumps back to paginated page, but this is noted in #1105

We did used to have asterisks on the edit profile page but these seem to have been lost. capture

I'd suggest three actions:

Do you agree @stephaniesimms?

stephaniesimms commented 6 years ago

sounds good to me @sjDCC. @briri please address the first two bullets above. created a new issue #1129 to reinstate asterisks throughout the site.

stephaniesimms commented 6 years ago

Edinburgh org data is working now - no more error. But none of the filters work for table columns @briri . Can you confirm if these are being addressed by another issue? If so we can close this one.

sjDCC commented 6 years ago

I searched orgs and then reordered data and it worked on so I think this is good to close out. By all means reopen though if not