search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Super Admin: ActiveAdmin replacement #132

Closed vyruss closed 7 years ago

vyruss commented 7 years ago

We need to replace ActiveAdmin with something simpler, more minimal, and preferably without a DSL to learn.

How does https://github.com/thoughtbot/administrate look? Demo: https://administrate-prototype.herokuapp.com/admin

vyruss commented 7 years ago

Fixed by b54c1cf3e3d35a53ddaacb4e5ae202191e1d7d66 ? =)

briri commented 7 years ago

I think we should only build out the controllers for the 2 use cases @sjDCC mentions in #131 and the few lookup tables we maintain (e.g. identifier_schemes, languages, etc.) because they have no other mechanism for maintenance beyond direct DB editing.

briri commented 7 years ago

re-opening because it has not yet been part of a PR

stephaniesimms commented 7 years ago

This doesn't seem to be working correctly with all of the html litter and red "Confirm...data method" messages in the last column of each table (screenshot below)

super-admin

vyruss commented 7 years ago

This looks like an en_US translation issue, @briri can you try copying config/locales/administrate.en_GB.yml to config/locales/administrate.en_US.yml (editing the 2nd line to say en_US)?

briri commented 7 years ago

The file does exist. It looks like passenger needed to be restarted. The translations appear to be working now.

sjDCC commented 7 years ago

@stephaniesimms this all looks ok to me. Good for you now too?

stephaniesimms commented 7 years ago

@sjDCC @vyruss I receive the errors below when I try to Edit or Destroy users. Everything else working as expected.

Edit user screen shot 2017-04-10 at 9 15 38 pm

Destroy user screen shot 2017-04-10 at 9 12 05 pm

vyruss commented 7 years ago

@stephaniesimms deleting users is a big no-no due to data integrity issues so that's as expected. I'll look into the edit issue

sjDCC commented 7 years ago

Perhaps we should remove the destroy user button if deleting is a big no no? Or change it to 'archive' or 'deactivate' user. There's no point having something there that we don't want people to do.

I'm getting the same error with being able to edit users. I assume this page shows their permissions?

Should we remove the destroy option under 'organisations' too as I guess we'd run the risk of being left with data integrity issues again then

stephaniesimms commented 7 years ago

@vyruss @sjDCC we definitely don't want to provide admins w/ability to delete users, per our discussion a couple of weeks ago. So we shouldn't present the expectation that they can—I agree that we need to remove the "Destroy" button. I agree w/the suggestion to remove "Destroy" under Organisations too.

vyruss commented 7 years ago
  1. Ability to destroy removed from super admin for now. A more sensible action will be implemented to disable users in the future.
  2. Edit bug fixed.
  3. @sjDCC can you please check on dmponline-test ?
stephaniesimms commented 7 years ago

moving this back as it's not deployed to Roadmap server for UAT yet

stephaniesimms commented 7 years ago

Edit user working as expected. Removal of Destroy option confirmed. Good to go. Closing out.