DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

Default template losing 'publicly visible' status when versioned #1415

Closed briri closed 6 years ago

briri commented 6 years ago

Please complete the following fields as applicable:

Expected behaviour: The default template should still be visible on the 'Customizable templates' tab of the templates page and available to researchers when they create a plan.

Actual behaviour: When the default template is versioned, it's visibility is set to 'organisationally visible' if the org that owns it is not a funder

stephaniesimms commented 6 years ago

@briri when i test on roadmap and dmptool stage the customized default (Digital Curation Centre) template remains visible in the customizable templates table for admins. but now I can also see the customized version in the public DMP Templates list (see screenshot 1). each time i edit/version the customization it updates this template.

the customized version of the template should not appear in the public list. customizing a template should not update the last edited date for the public template either (although i assume this will be resolved once you complete template versioning work).

I also cannot access the customized default template when I create a new plan. when I go through the create plan wizard and tick the box for "No funder associated" I should see a dropdown list of org templates and the customized default template. But the current behavior doesn't result in a dropdown and instead serves me up an org template "Copy of NIH-GDS" (screenshots 2-3). If i tick both of the boxes for No org and No funder, I do get the default template but not the one customized by UCOP (my org).

screen shot 2018-04-25 at 5 06 37 pm screen shot 2018-04-25 at 5 29 39 pm screen shot 2018-04-25 at 5 29 54 pm

briri commented 6 years ago

ok. this is a larger issue than I originally anticipated. I can exclude the default template from the public templates page, but the current logic behind the create plan page would never find a customized version of the default template.

stephaniesimms commented 6 years ago

after further discussion, closing this issue and @briri is creating two new issues to address after template versioning is done