Create email notification system

[stephaniesimms]

Create email notification system

• new tab under Edit Profile for 'Notification Preferences' (see blue notepad in UX wireframes for functional specs)

UX wireframes @JEK-III : http://h90c3m.axshare.com/#g=1&p=profile

Pivotal ticket: https://www.pivotaltracker.com/story/show/119416081

DMPTool notifications - review/revise this list

[stephaniesimms]

@JEK-III please update wireframe w/following changes http://h90c3m.axshare.com/#g=1&p=profile__first_login

• add third tickbox under "All users" for: "A plan has been shared with me"
• move first tickbox "New permissions granted to me" down to third position and revise to say: "Admin privileges granted to me"
• change second title to: "DMP owners and co-owners"
• delete second tickbox under that title "I have been made co-owner of a DMP"
• add third tickbox under "DMP Administrators" for: "A user has requested feedback on a DMP"

[stephaniesimms]

@bhavi I asked @JEK-III to revise the UX wireframes (comment above). all email text is in the Google doc, organized as follows:

• 2 emails from devise gem. update w/revised text.
• existing emails. all need to be updated w/revised text.
• new emails to add (starting on p.4 of doc; ignore the RECOVER ACCOUNT email for now since we're still sorting out the workflow)

Let me know if you have any questions. https://docs.google.com/document/d/1Zt3QfPZ2q6yMOCVFOevXviwRX-XbZeGSxAAvbRa9w-M/edit

[stephaniesimms]

wireframe revision still pending. @bhavi I tested the current implementation and can't save changes. anything I do to change my selections produces the error message in the screenshot below. the save button is always gray - i think it should always be orange, or turn orange as soon as a user makes any changes to then prompt them to save.

After further testing, I can't save anything on the Edit Profile pages. I get the same error message for Personal Details and Password changes.

[JEK-III]

Wireframe updated and re-named to reflect updates to the login workflow: http://h90c3m.axshare.com/#g=1&p=profile

[stephaniesimms]

@bhavi wireframe is ready for revision to Notification Preferences menu.

I re-tested the save functionality: now it only allows me to save changes if ALL info in all tabs of my profile menu is complete. So I changed something in my email preferences, clicked Save, and received a message that the save was unsuccessful because I needed to specify an Org in my Personal Details page.

The desired behavior is for each tab menu to have independent save/update functionality.

[stephaniesimms]

@bhavi When I click to save changes on my Notification Preferences, currently it takes me to the Personal Details page and displays a message that my changes were saved. Desired behavior is for the same tab/page to reload for whenever a user changes something in their profile. So I would expect to still be on the Notification Preferences page after my changes are saved w/the message displayed above it. And likewise for changes to the Personal Details or Password pages.

• There should also be some white space separating each tab (see wireframe)
• make ORCID all caps and connect lowercase: "Create or connect your ORCID iD"
• add a tiny bit of white space to the left of the green ORCID logo so it's not touching the button edge

[bhavi]

Tab reload issue fixed. Also added the minor CSS fixes and deployed on dev.

[briri]

Clicking save produces an error undefined method[]=' for nil:NilClass`

[xsrust]

Investigated the save error and it seems to be due to a key which is expected in the hash, but is not found. Since the new approach in #481 will be to only store deviations from the defaults, It should be robust to missing keys, so This ticket can potentially be closed

[stephaniesimms]

This is working as expected now. Email notifications themselves will be addressed in related issue

442 Closing issue.