search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Copy plan option to create a new one #149

Closed stephaniesimms closed 7 years ago

stephaniesimms commented 7 years ago

Add option to copy an existing plan to plan creation workflow as in DMPTool

See UX wireframes @JEK-III : http://h90c3m.axshare.com/#g=1&p=my_plans__ideal

Screenshot of DMPTool create plan workflow dmptool_create_copy_plan

Screenshot of current DMPonline create plan workflow dmponline_create_plan

DMPonline screenshot of potential Copy button location on My plans page dmponline_dashboard_copybutton

briri commented 7 years ago

follow the Template.deep_copy approach

stephaniesimms commented 7 years ago

tested and this is working as expected on Dev. I'll check w/ @sjDCC to see if we want to drive the user to edit the plan details immediately, as opposed to having to click on the "Edit plan details" button. this would prompt them to change the plan title. there are some issues with guidance selections not being displayed when you click through to answer questions, but I think these are being addressed via other issues.

screen shot 2017-05-25 at 11 21 45 am

stephaniesimms commented 7 years ago

@bhavi just following up to confirm that we do want to drive the user to edit the plan details immediately after clicking to Duplicate their plan

stephaniesimms commented 7 years ago

Clicking Duplicate throws the error below. This occurs for plans based on all templates. Also I can only create a new plan using the default template. If I select any funder from the list the "Create plan" button remains grayed out and will not allow me to continue @briri . I think this is a template error.

screen shot 2017-06-01 at 2 00 00 pm

Can't select a funder to Create plan - button grayed out screen shot 2017-06-01 at 1 57 59 pm

Can only select default template screen shot 2017-06-01 at 1 58 31 pm

stephaniesimms commented 7 years ago

I can successfully Duplicate a plan now. @bhavi we do want to drive the user to edit the plan details immediately after clicking to Duplicate their plan.

stephaniesimms commented 7 years ago

This is working as expected now.

sjDCC commented 7 years ago

I guess the copy plan function is 'duplicate' in this list? copy-plan

The term 'copy plan' might be better. 'Duplicate' to me suggests replicating as a backup, not necessarily copying to edit or create a plan from an existing one. Maybe we should check terminology with users? The dropdown flickered on and off for me too. It didn't stay open when you clicked it. I think this is still being implemented though so probably in hand.

I got an error when clicking duplicate. Not sure if this is because I've only just created plan and it has no content in. Worth checking if it still works for you @stephaniesimms or if another bit of code has knocked this off copy-plan-error

stephaniesimms commented 7 years ago

I get the error now too. @briri is going to check on it tomorrow. @JEK-III can you chime in about why you recommend "Duplicate" ?

JEK-III commented 7 years ago

I think Duplicate is slightly better because Copy sounds like step one of Copy/Paste.

Google docs uses "Make a copy"– we could certainly say that instead.

sjDCC commented 7 years ago

'Make a copy' sounds good to me, unless we want to keep it all one action word so dropdown list is comparable throughout.

@dsisu - as a non-native English speaker, is one clearer to you than another?

vyruss commented 7 years ago

Make a copy sounds good to me too.

jollopre commented 7 years ago

Make a copy seems more natural to me too. I tend to associate duplicate to inconsistencies in data.

briri commented 7 years ago

This should be working now. Changed the language to 'Make a copy'. Thanks to @bhavi for resolving the link issue

stephaniesimms commented 7 years ago

that was a hot topic. will update copy template related issue #148 accordingly. everything looks good on stage now. closing this issue.