search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Email change bug on user profile page #173

Closed sjDCC closed 7 years ago

sjDCC commented 7 years ago

A user was unable to change his email address on the current live DMPonline service. The page saves but the value doesn't change. Check this bug doesn't exist in roadmap code

briri commented 7 years ago

blocked by #171

briri commented 7 years ago

The system requires the user to enter their 'Current Password' in when changing their email address which seems reasonable since its potentially the user's mechanism for logging in.

The real issue is that the page is not displaying any error messages to the end user and so they do not understand that they must also provide their password.

We should hold off on this fix until the fastgettext localisation work is complete and in DMPRoadmap/roadmap development branch because it requires new translatable messaging.

The solution to this issue should work towards solving the larger #175

xsrust commented 7 years ago

logic for changing email (and all other user attributes) updated in https://github.com/DigitalCurationCentre/roadmap/commit/970d646f0fe8db0198eb2013077d03edc2271b53. Additionally, error messages were added to the page.

briri commented 7 years ago

this looks good. We may want to consider putting some messaging on the form, /views/devise/registrations/edit.html.erb to let the user know that the password will be required. That way they won't need to wait until they submit and we get the error response back from the server.

Once we get this out on the servers for testing we can ping the UX team and have them take a look. It might make more sense to reorganize the form layout.

stephaniesimms commented 7 years ago

Messages implemented. Everything working as expected. Agreed that we should ask UX team to evaluate the form layout--will ping them.