DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 109 forks source link

spaces under comment save button #1891

Open Yu-Chieh-Henry-Yang opened 6 years ago

Yu-Chieh-Henry-Yang commented 6 years ago

Expected behaviour:

In this image, you can see that under the save button, there are big spaces: screen shot 2018-09-25 at 4 33 31 pm

In the code base (app/views/notes/_layout.html.erb), that space looks like this:

      <div class="row">
        <div class="col-md-12">
          <div class="pull-right">
            <%= link_to(_('Add Comment'), "#note_new#{question.id}", class: "btn btn-default note_new_link", role: "button", style: "visibility: hidden") %>
          </div>
        </div>
      </div>

I expect this code to be deleted becuase we can already create new comment using the box. Where is this code used? Is it safe to be removed?

stephaniesimms commented 6 years ago

evaluate w/related issue #1886

magdalenadrafiova commented 4 years ago

@pherterich @mariapraetzellis I am not sure whether this is something we want to consider - I went to the comment area and there are still big spaces moving to backlog, usability

Screenshot 2020-07-07 at 10 20 36
xsrust commented 4 years ago

I think it would be a good idea to evaluate the display of that area of the tool,

We've additionally had many requests about differentiating out plan-review comments visually.

pherterich commented 4 years ago

I think Rachael will look at comments as part of the UX testing she will do on that area, so let's see what she will come up with.