DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

Ensure spell check is enabled for smaller data entry boxes #2169

Open magdalenadrafiova opened 5 years ago

magdalenadrafiova commented 5 years ago

From our accessibility testing the following was mentioned: The smaller text boxes e.g. what project are you planning did not have spellcheck enabled but the larger free text boxes e.g. Project Abstract did.

sjDCC commented 5 years ago

I'm not 100% sure how to test this one. On one plan I have I can see 'NERC' underlined in red in a project details abstract. This may be coming from browser rather than an accessibility feature in tool.

Any advice @johnpinto1

magdalenadrafiova commented 4 years ago

I am sorry I do not know how to test this one - I am adding this to our meeting on Tuesday morning so Sam/Ray can show us

johnpinto1 commented 4 years ago

@sjDCC @magdalenadrafiova spellcheck: "true" is a HTML 5 attribute that has been added to all text field tags. So the browser if it supports HTML 5 will highlight spelling errors for your locale.

magdalenadrafiova commented 4 years ago

Now when I go into create a new project and I start filling the details there is a spell check enabled for the front page - for the title of the new project. Seems fine closing this. @sjDCC @xsrust

mariapraetzellis commented 4 years ago

Reopening b/c we're not seeing the feature in tinymce boxes. Check plugins to enable spellcheck plugin. John on enabled browser spellcheck

xsrust commented 4 years ago

Having a look at the types of spellchecking that TinyMCE supports, I think I'd still rather go with the browser-based package rather than us running a spellchecking service. See: https://www.tiny.cloud/docs/general-configuration-guide/spell-checking/ for more details on the options given to us by TinyMCE.

mariapraetzellis commented 4 years ago

I'm not clear if this was enabled @xsrust? I don't see the spell check feature in data entry boxes.

I have heard from several users that they would like to see a spell check feature, so unless it's a real drag on the application I think it is worth enabling. My Chrome browser was not picking up spelling errors when filling out a test DMP in the app.

screenshot-dmponline-dev dcc ac uk-2020 02 03-15_09_20

magdalenadrafiova commented 4 years ago

that has not been deployed just yet

magdalenadrafiova commented 4 years ago

seems to be working @mariapraetzellis you want to try too? screenshot-dmponline-dev dcc ac uk-2020 02 04-17_04_21

sjDCC commented 4 years ago

Looks good for me too. Closing out

mariapraetzellis commented 4 years ago

Looks good to me as well.

dsisu commented 3 years ago

Sorry to have to re-open this but the spell checker still doesn't work for all data entry boxes. For example, notification title box (it works for the body box).

johnpinto1 commented 3 years ago

Will look at this now.

pherterich commented 2 years ago

@dsisu this works for me now, are you okay to confirm and close out or update with details of where you still encounter issues please?