DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Adjustments to Contributors #2481

Open briri opened 4 years ago

briri commented 4 years ago

I'm happy with the separate tab and think the functionality to add contributors works well but have a couple of suggestions. Capture new-contrib

  1. We should rename the tab "Collaborators" not "Contributors" as that's more even. Maria, Magdalena and I discussed this on a Product Manager call

  2. We should pre-enter the plan owner as PI like we did previously on project details and allow them to amend entry. Pre-fill as much as possible from edit profile e.g. ORCID etc. If we roll this in with the plan co-authoring feature, perhaps text like: "Please list project collaborators to ensure credit for contributions and assign authoring / viewing permissions for the DMP"

  3. Are the terms "Data Manager" "Principal Investigator" and "Project Administrator" from CRedIT Taxonomy? May be good to link out to that here or show them as indexed, controlled terms somehow? On the overview table like for RoR entry?

  4. We discussed merging this with the table under "Share" and having the Collaborators tab be where users can list team members and assign plan editing roles. This may be a secondary piece of work to avoid delays now. It could fit under actions feasibly e.g. "Assign privileges" and popup a modal like on admin interface? Or write it into main entry form. To be discussed with UX

credit-link collab

sjDCC commented 4 years ago

We've had a suggestion on this from the user group:

"A handy feature especially for funded, collaborative and big scale projects as it contributes to the accuracy of the details of the project. However, it might be not useful and confusing for PhD research projects undertaken by one researcher. For this reason, it may be more functional if it could be added as an optional “on off” tab, similar to the “request Feedback” tab."

We don't currently record whether the plan is for a PhD student so we'd need to add that element if we choose to configure on/off. Would also need to test wider interest and demand for this.

If we merge the share function with the contributors tab then I'm not sure we would want to ever configure this off as people always need options to add co-owners, editors and viewers.

briri commented 3 years ago

The list of roles is a subset derived from: https://casrai.org/credit/

We have merged the contributors section with the collaborators section from the share tab on the DMPTool. We could easily send that refinement as a PR to DMPRoadmap if desired:

Screen Shot 2021-02-26 at 7 50 51 AM

Note that we also renamed the old 'Share' tab to 'Finalise/publish'. This tab contains the visibility section and will also contain the future DMP ID (aka DOI) section in the future

magdalenadrafiova commented 3 years ago

@briri just a question - will there be all contributors roles listed from https://casrai.org/credit/? Or just the few that are currently visible? We currently can see data manager, principal investigator, and project administrator

briri commented 3 years ago

That is all we have so far, mostly due to the perception that many of the roles within the list are a bit confusing. For example 'Writing - original draft' could be construed as the person writing the DMP itself or the subsequent journal article.

It would be fairly easy to add/subtract roles as needed. The subset of roles is defined here: https://github.com/DMPRoadmap/roadmap/blob/d73a3495b8601abe9bb9f3a5793c1706d9970d36/app/models/contributor.rb#L60