DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

Formatting is strange on the edit plan page #2500

Closed magdalenadrafiova closed 2 years ago

magdalenadrafiova commented 4 years ago

The formatting is not working well - the guidance is appearing over the text/questions and it is not possible to hide this.

Screenshot 2020-04-29 at 15 52 02
briri commented 4 years ago

hmm. We had to restrict the size of both the guidance section and the answer text areas due to the available real estate on the page.

Would it work to add a horizontal scroll bar to the Tinymce text area? That would allow the user to scroll to see the full table.

I also notice that the Example answer is not staying inside the blue boundaries of its container

magdalenadrafiova commented 4 years ago

I personally think that to scroll horizontally on the page is not ideal but could be possibly a temporary fix for now before we do more changes to DMPonline pages in general and just make the windows more wide across the screen if that could be possible in the future? any thoughts on this @sjDCC and @mariapraetzellis

sjDCC commented 4 years ago

Yes, I think we need a horizontal scroll for now. Or we supersede this with improved layout. I'm inclined to add all guidance and examples below the text box to give more space for that. We have been discussing a major reworking of the layout on this page. The main text box needs to be bigger - full width? - and comments perhaps just as an icon until expanded? Guidance and example answers could both display beneath the text box area to make better use of space.

We also need to think about which elements fit best in which tabs on the main plan workflow. See #2351 for ideas

briri commented 4 years ago

ok. Is this something we want to prioritize over the rails5 work? If so we can send the patch directly to the master branch.

I think it will be more efficient to change up the layout of this page when we do the work to change up the contributors, sharing, etc.

Also wondering if we can somehow limit the width that we allow in general. I can foresee someone creating an extremely wide table. While we could allow that within the browser it will likely not render when exported to PDF. Not sure how best to address a scenario like that.

sjDCC commented 4 years ago

Yes, I think it can wait til after Rails 5.

Good point about limiting width

raycarrick-ed commented 4 years ago

Tried this with latest development branch. Added a ridiculously wide table and a horizontal scroll bar appeared for the tinymce box. So maybe this isn't an issue on the latest codebase.

dsisu commented 3 years ago

This issue was raised several times during the DMPonline Usability Exercise in 2020.

mariapraetzellis commented 3 years ago

We should look into the TineMCE scroll bar- @martaribeiro will look into this.

mariapraetzellis commented 2 years ago

We should test this again once we deploy the expandable comments panel.

pherterich commented 2 years ago

@pherterich to check if collapsible guidance makes this redundant

pherterich commented 2 years ago

It does, closing out