DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 110 forks source link

User accounts table display goes rogue when displaying shibboleth identifier #2647

Closed pherterich closed 4 years ago

pherterich commented 4 years ago

Expected behaviour: I'm not entirely sure, none of the previous versions seem to display the shibboleth identifier in that table but I guess the table should still align with the rest of the design.

Actual behaviour: The user accounts table layout doesn't wrap properly when a shibboleth identifier is displayed in the "identifiers" column. dmponline table wrap

Steps to reproduce: E.g. go to https://dmponline-test.dcc.ac.uk/org/admin/users/admin_index and filter by "show only admins" or sort by Last activity.

xsrust commented 4 years ago

replace Shibb Identifier in table w/ a presence message (retain display of identifier on user-profile)

mariapraetzellis commented 4 years ago

Let's show the logs for Shibb and ORCid. The user can click through to view the actual id.

raycarrick-ed commented 4 years ago

Fixed in: https://github.com/DMPRoadmap/roadmap/tree/issue_2647 in the table it will now just have the names of any identifiers present when you click through to the user edit page it will display those identifiers the identifiers are just displayed as I don't think it makes sense to allow them to be edited. The shibb ids can still be long so depending how people find it we may need to revisit their display. But this should do for now.

mariapraetzellis commented 4 years ago

Not sure if this got merged? I'm still seeing the full shibb ID in the table:

screenshot-dmponline-test dcc ac uk-2020 09 04-13_20_19

mariapraetzellis commented 4 years ago

Looks good now.