search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
106 stars 109 forks source link

Unable to complete a feedback request #2692

Closed pherterich closed 4 years ago

pherterich commented 4 years ago

Expected behaviour:

When being done with providing feedback, clicking the "complete" action in the notification overview should send an email to the user and remove the plan from the overview

Actual behaviour: Getting the following error message " Error: Unable to notify user that you have finished providing feedback."

Steps to reproduce: Click the "complete" button for any of the plans submitted for feedback on https://dmponline-test.dcc.ac.uk/org_admin/plans

xsrust commented 4 years ago

Think this is actually due to the plan->org_id link that propagated up from the Master branch (so a data-issue with DMPonline-test) I'm running the rake:task that came along with that work and will re-ping for testing once that's finished running

xsrust commented 4 years ago

That's done running now

pherterich commented 4 years ago

Works for me, @magdalenadrafiova do you want to confirm and close?

magdalenadrafiova commented 4 years ago

comments and hitting feedback complete worked well. closing :)