search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 110 forks source link

System messages displaying in "Current privileges" column for users #2698

Closed magdalenadrafiova closed 3 years ago

magdalenadrafiova commented 3 years ago

I am not sure whether this is rails5 bug or whether this is actually how the logic of dmponline-test works, but I do not see the 'edit' privileges tab in the dmponline-test at all.

pherterich commented 3 years ago

It's there, but it's hiding behind loong weird system messages

priviledges

magdalenadrafiova commented 3 years ago

so is this how it is going to be managed? On the 'main' interface it is one extra column:

Screenshot 2020-10-05 at 14 35 38
pherterich commented 3 years ago

Makes sense to me, no need for 2 columns for that, especially as we added the identifier column.

pherterich commented 3 years ago

Renamed to the things that's still an issue, assigning privileges worked fine for me.

xsrust commented 3 years ago

The system messages are related to the Translation.io upgrade ( it does not like to translate the empty string"" ) @briri has already caught this and fixed it in: https://github.com/DMPRoadmap/roadmap/pull/2696/files#diff-da8699dd5cc68fd9857aa35f34f54d5dL6

pherterich commented 3 years ago

Looks good now, thanks for fixing 😄