search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

Migration error on example answers #270

Closed sjDCC closed 7 years ago

sjDCC commented 7 years ago

Creating a plan on DMPonline test has shown more data migration issues.

Example answers are showing up on a plan I have created for the AHRC, based on being a user at the University of Edinburgh. However the UoE has not customised the AHRC template. The example answer being displayed comes from the University of St Andrew's. example-answer-migration-error

Looking at the live DMPonline data, 4 institutions have added examples to this one AHRC question (St Andrew's, York, Lancaster and Liverpool). What has happened to the other data?

The AHRC guidance has also been transposed into UoE guidance. A known issue reported in #263

xsrust commented 7 years ago

related to (and blocked by) #223, which will move example answers into the annotations table. Once that is done, we can check to see if the problem is with the data and that the organisation associated with the guidance is wrong, or if the problem is with the display logic.

xsrust commented 7 years ago

Addressed in migrations: https://github.com/DMPRoadmap/roadmap/commit/0c74f1ad63f0e330525b9c3f06b4c5d6029332fb https://github.com/DMPRoadmap/roadmap/commit/ebc5ed836900e629c2506d91b9265920500c8a33

Data will need to be re-migrated in order to facilitate testing of this ticket

sjDCC commented 7 years ago

This issue is still occurring - see ticket #381 recorded today

dsisu commented 7 years ago

Trying to test AHRC template but can't select it. I'm working on dmponline-test. ahrcliv See screenshot.

sjDCC commented 7 years ago

@dsisu I think this is because it's not a controlled entry from the list. Try typing the funder again and select AHRC once you've typed 'Arts...'

dsisu commented 7 years ago

That's what I did and it doesn't work. It also inserts & instead of &. We should just use 'and' if html coding causes problems.

vyruss commented 7 years ago

@dsisu that is a separate issue with the new combobox which doesn't select names which contain ampersands.

dsisu commented 7 years ago

If it's a separate issue do you want me to raise a separate ticket? You seem to be aware of it.

vyruss commented 7 years ago

@dsisu we'll handle it under #124

sjDCC commented 7 years ago

We need it to work for now so have changed the ampersand to 'and' and it lets you create a plan for AHRC.

Should I change this on the current live site so the correct data gets pulled through?

vyruss commented 7 years ago

It's a workaround, but yes @sjDCC please do change it until we can tackle the dropdown.

xsrust commented 7 years ago

this is fixed on dmponline-test data:

screen shot 2017-05-31 at 2 26 36 pm

sjDCC commented 7 years ago

Tested for several orgs and is working. Closing out.