search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

Why are there no traces of archived notes? #2817

Open nicolasfranck opened 3 years ago

nicolasfranck commented 3 years ago

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

3.0.1

Expected behaviour:

One should be able to see a trace of archived notes in the edit form of a plan. In the old DMPonline_v4 this was done by showing "comment removed by " with a line through it. Now it simply discarded:

https://github.com/DMPRoadmap/roadmap/blob/master/app/views/notes/_list.html.erb#L3

Doesn't that result into a strange conversation, where someone can actually redraw his/her comment, and the next comment answers to something of which there is no trace?

briri commented 3 years ago

yes, I suppose that is a possible scenario. It has not come up as an issue for us because I think this feature does not have a lot of adoption for us (We have around 50k plans in our system here and only around 2,500 comments in the notes table). Most of our users seem to manage their conversations offline via email.

@raycarrick-ed and @martaribeiro have either of you heard any complaints about this scenario in your instances?