DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

DB Cleanup #2818

Closed briri closed 3 years ago

briri commented 3 years ago

While writing up some DB schema info I realized we have some cleanup to do:

Be sure to update the wiki doc after these changes have been made!

Remove the following columns (once confirmed that they are no longer used):

Drop the following tables:

Things to do after some research and refactor:

nicolasfranck commented 3 years ago

@briri if plan.funder_name will be removed, and the plan wizard requires an existing funding organisation, then it is not possible anymore to supply a custom value? Just something to know for my migration. This was since version 2.2.0 I believe?

briri commented 3 years ago

The newer Org typeahead allows the user to type in their own value or select from a combination of an existing local DB record or an Org from the ROR API.

Here's a screenshot of what one of the Org typeaheads looks like:

Screen Shot 2021-02-25 at 12 51 54 PM

There are a few scenarios for Org selection depending on where they are located in the UI:

For an easy way to disable the ROR integration, for your use case since you have a restricted set of Orgs if I remember corretly, would be to set the config/initializers/external_apis/ror.rb initialize to 'inactive' This will switch it to only allow local DB and user entered values.

I suppose I should add a wiki page about this ;)

pherterich commented 3 years ago

@raycarrick-ed to run on DMPonline

briri commented 3 years ago

Did not end up removing orgs.is_other and users.other_organization