DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Cannot create plan if No Org and No Funder #285

Closed stephaniesimms closed 7 years ago

stephaniesimms commented 7 years ago

When I have no Org affiliation and try to create a new plan by selecting 'No Funder' I get the following error (screenshot). Expected behavior is to provide the default DCC template.

Related issues #257 and #267 (closed)

no-funder-no-org

vyruss commented 7 years ago

Fixed by latest PR

dsisu commented 7 years ago

This works for me

sjDCC commented 7 years ago

This appears to work as the plan creates, but you can't edit anything. On staging when I click to edit the plan I get the following error. view-dmp error

On DMPonline it's a worse error. No phase / DMP appears at all. dmponline-test

I've tried digging around on the admin side to see what's going wrong as I suspect it's a template error. This uncovered more things. When I view the Tuuli (default) template on roadmap staging, I can't edit or view any of the versions. All give a "something went wrong error" roadmap-tuuli

I tried changing my institutional affiliation to Helsinki uni to see if it was just an issue with the default template and that gave a stranger issue. It was showing a GU template. Checking the Tuuli live site, the helsinki template is called general data management so not sure where this has come from. view-helsinki-template tuuli-live

Checking the DMPonline default template, this indicates it is published. Viewing the history table there are two versions, The first is unpublished and weirdly has no phase / set of questions. The supposedly published one is showing as unpublished here and gives a 404 if you click to view the plan/template. dmponline-default no-phase whatever

You also get a 404 if you click to edit the template. This creates a new draft version but also seems to have duplicated this. See history table now. template-versioning

I really can't figure out what's gone wrong here, but I think data has got mixed up

stephaniesimms commented 7 years ago

we noted a few weeks back that there are still some issues with the data migration and it's difficult to distinguish between issues produced by bad data and those produced by bugs in the system. you might try testing the migration @sjDCC before attempting to disentangle things here.

sjDCC commented 7 years ago

This is still not working.

If I create a plan with no funder and no org, it tells me it has successfully created based on the generic template but no DMP content displays. I think this is linked with the various template tickets so moving back to in progress to pull back through to test again once these are deployed

still-not-working

vyruss commented 7 years ago

I cannot replicate this now. Steps:

  1. I change my profile to have no org
  2. I create plan, ticking "no research organisation" and "no funder"
  3. I can edit "Generic DMP"

Perhaps the Generic template had not been copied over properly as a result of previous dodgy migrations.

sjDCC commented 7 years ago

This is working now. Closing out