Change password not working as expected

[stephaniesimms]

I received a variety of different errors and weird system behaviors each time I changed my password (screenshots below). The most frequent error is that I get kicked out of the system after clicking to 'Save' the new password (second screenshot), but when I attempt to login again my password is updated with the new one.

It looks like my new password is recorded/updated each time but nothing else works as expected. I should just receive a message that my password has been updated. @sjDCC can you confirm this and whether I should also remain signed in?

First errors had messages like this. I checked with and without entering my First and Last Name and that made no difference:

Then I got this error repeatedly and could not reproduce the above error:

[vyruss]

It says the translation that's missing is for "password too short" so @jollopre perhaps it's simply a missing i18n string issue?

[jollopre]

I don't think so. It seems something more complex since changing password signs you out. In addition, when signed in with the new password does not redirect to /plans.

[briri]

We removed the confirmation email requirement from Devise which could be contributing to this issue. There's a private method in the registrations_controller that's likely the issue. It determines what message goes out

[sjDCC]

Just to confirm, the password change should just give a confirmation message not log you out

[sjDCC]

Password now saves correctly on both DMPonline test and staging and keeps user on same 'edit profile' page. However the action of saving changes resets the language preference to German. Is this linked to #293?

Does this ticket need to be left open or a new one generated @vyruss @briri It seems #293 will be fixed as part of #230 which should be pulled in soon so maybe close this ticket for now?

[vyruss]

Yes, I'd say close it. There's​ #293 for the default Language issue.