possible to add contributor without a name - even though it appears as compulsory field

[magdalenadrafiova]

@raycarrick @briri I am testing on DMPonline-dev the latest 3.3 release. Not sure The contributor name appears as compulsory field but when I left it empty it was alright to save:

See contributor without a name:

[briri]

The logic in the code requires one or the other (name or email). Should we actually require both or is one more important?

I don't necessarily think it should dictate how we collect data in the UI, but the RDA Common Standard requires the Name, a role designation and the ORCID (or some identifier) be present.

Whoever addresses this ticket should also remove the phone number per #2941

[johnpinto1]

Will look at https://github.com/DMPRoadmap/roadmap/issues/2941 next. Have a PR see above.

[magdalenadrafiova]

@johnpinto1 both still appears as compulsory fields on dev follow up with @dsisu once fixed so she can re-test and close

[johnpinto1]

The view is displaying wrong info. The code saves either name or email, but view shows incorrectly that both name and email are required.

[johnpinto1]

Trivial fix done and PR created https://github.com/DMPRoadmap/roadmap/pull/3120

[pherterich]

Just catching up with things as part of trying to understand what the latest release covered: how is it obvious to a user in this new version that either name or email needs to be provided? Do we provide a meaningful error message if it isn't? Should we add a sentence saying that one of the two fields needs to be filled?

[raycarrick-ed]

This is a good point. @johnpinto1 how easy would it be to add a message to that effect? Fill in at least one of these fields?

[johnpinto1]

@raycarrick-ed & @pherterich It should be trivial. Famous last words. Its just adding an text.

[pherterich]

"Please provide either Name or Email in addition to the fields indicated as mandatory using *"

Other suggestions on how to phrase this @dsisu @mariapraetzellis ?

[dsisu]

If the logic makes this easy to implement, I would say make both name and email address fields mandatory (and marked as such).

From the users' perspective, as readers, it looks much better if all contributors are named. The email address can be very different from the name and give no obvious indication who the contributor is.

From the user's perspective as the form-filler (the author of the plan), it's not a lot of information to ask of them. They must have spoken to their contributors so they will probably have their name and email address close to hand.

If we don't make both fields mandatory, then we Patricia's suggested wording is fine.

[johnpinto1]

@dsisu CDL requires either name and email address fields , so it would be better to not require both mandatory.