search

DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Invitees should only get one email, not two (Plan Sharing) #307

Closed vyruss closed 7 years ago

vyruss commented 7 years ago

When sharing plans, (unregistered) invitees should only get the invitation (to register) email and not a second plan sharing notification email as well.

vyruss commented 7 years ago

Slightly related to #268 so will go into same PR

sjDCC commented 7 years ago

This works and only one email comes out.

The email notification was missing the application name in the title though, despite it being entered in the email text. Is this seeding from a different place? 307-email

If you can ensure this is entered then all is good to close out.

vyruss commented 7 years ago

@sjDCC this is fixed now

sjDCC commented 7 years ago

This is correct on the email when a plan is shared with an existing user but not on the email sent when someone is invited to register.

@stephaniesimms could you share plan with an unknown account to double-check please? Email still gave me %{application name} in title

vyruss commented 7 years ago

I just tested on dmponline-test and it has the correct behaviour.

stephaniesimms commented 7 years ago

This is working as expected now. Closing out.

screen shot 2017-06-07 at 2 26 15 pm