DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

In order for the admin contact to appear - URL has to be added too - can this be changed? #3114

Open magdalenadrafiova opened 2 years ago

magdalenadrafiova commented 2 years ago

When organisation details are edited and contact email that is compulsory field is added it does not appear at the header, see example:

Screenshot 2022-02-25 at 09 59 02

However, when I add the URL the contact details appear, see below:

Screenshot 2022-02-25 at 09 59 58

Could we make it so the admin details will appear regardless whether the URLs are added?

briri commented 2 years ago

This has been merged. @raycarrick-ed, @martaribeiro and @johnpinto1 if you have customized the header that displays the Org's links and email you will need to pull in this fix to your customized copies.

pherterich commented 2 years ago

@dsisu - can you please check if this is addressed for us now and can be closed here?

dsisu commented 2 years ago

@pherterich I'm not sure I fully understand the wording of this issue. Is it about being stuck with the Leiden University Medical Center (LUMC) look and feel even if you change university or is it about your new organisation admin details not appearing in the header?

If I go to the LUMC instance at https://dmponline.lumc.nl and then edit my profile as a user to change my organisation to say Dundee or Edinburgh, email and other admin details for my new organisation appear in the header, without me having to refresh the URL, without me having to find the right URL for my university (e.g. https://dmponline.ed.ac.uk/ ). I tested this by first assigning my organisation to Leiden University Medical Center (LUMC), then University of Dundee, then University of Edinburgh.

However, I am now a University of Edinburgh user (with the correct admin info in the header) but stuck with the look and feel of LUMC. Is this the intended behaviour? At some point, I still need to find t hat URL, https://dmponline.ed.ac.uk/ . I guess you'll think, well at least you have the correct help info, but it's still not neat. Ideally, we should find a way for the user to hit refresh and go to the new org look. I hope you see what I mean.

pherterich commented 2 years ago

Still the case on dmponline and -dev, @martaribeiro can you check how we could pull the changes in?