DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Several issues with institutional customisations of funder templates #335

Closed sjDCC closed 7 years ago

sjDCC commented 7 years ago

Is seems the data has gone awry when transferring institutional customisations of funder templates. There are several issues here so you may want to split these out into separate tickets, but I'm unsure how to untangle them.

Comparing live and test, St Andrew's haven't customised any funder templates, but when you check on the test site it suggested they've customised most. [On 2nd check, this may be a display error on DMPonline as looking at BBSRC and EPSRC, St Andrew's have at least added suggested answers to these if not more funders] funder-customisations funder-customisations-test

Clicking into these customisations raises several errors. The first is to do with the templates themselves. It seems the permissions are wrong on many. I'm presented with options to add phases and edit template details, when all institutions should be able to do is 1) add sections, 2) add suggested answers and 3) add guidance / annotations per question. It also suggests the template is unpublished which isn't the case - if it were it wouldn't be available to customise. It seems most say they're unpublished so the data is invalid. wrong-rights-customise

I can't see whether options to add sections, suggested answers and guidance / annotations are actually provided as each time I click the template page I get one of the following errors. I've not found one that opens yet. funder-customisation-error funder-customisation-error2

vyruss commented 7 years ago

The reason some templates appear as customised, is because we have had users from Org A use templates from Org B to create plans, which then causes legacy templates (combinations of phases/sections/questions valid at that point in time) to appear as customisations of Org B templates by Org A. @xsrust is aware of the issue and working on it

sjDCC commented 7 years ago

The main issue raised seems to be fixed so closing out. The problem with having additional edit rights when customising a funder template has been added to #373