DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Permissions to create or edit existing template customisations #373

Closed sjDCC closed 7 years ago

sjDCC commented 7 years ago

The button to edit existing content added to a funder template is missing. I have an option to add a section but not amend suggested answers or questions added to a section previously etc. Screengrabs from current live and test edit-customisation edit-missing

sjDCC commented 7 years ago

An update to this. The functionality to edit a section previously added seems to be working. I have now logged in as Brighton who added the "Project and funder details" section and see this in edit mode. The two issues are that:

  1. No questions display the button to add an example / suggested answer (or edit one previously added)
  2. Sections added by other orgs are also visible (though not editable) - noted in #371 customisation-functionality
sjDCC commented 7 years ago

Adding another point from #335 as this is related.

The edit rights on customisations of funder templates should be:

  1. Add example or suggested answers
  2. Add guidance / question annotations
  3. Add sections
  4. Edit any of the above details when added.

Currently users are being given an option to add a phase and edit template details, neither of which they should be able to do permissions

xsrust commented 7 years ago

The following screen shots depict the interface implimented. This feature needed to be re-written. In particular, the 'Add/Edit Annotations' text may need re-worked as of UAT. The button allows the user to edit both suggested_answer and guidance from one form.

screen shot 2017-06-06 at 4 20 30 pm screen shot 2017-06-06 at 4 20 55 pm

sjDCC commented 7 years ago

The buttons to add and edit annotations appear but clicking them doesn't open up an editable area, either on existing customisations or when trying to add new ones. Effectively i can't get @xsrust's second screengrab to show. Adding sections does open up an editable box though.

vyruss commented 7 years ago

@sjDCC please try again - I hadn't precompiled the javascript changes on the server.

xsrust commented 7 years ago

It seems to be working for me on dmponline-test

sjDCC commented 7 years ago

Yay! this is working. closing out

dsisu commented 7 years ago

If you clikc on 'add annotations' but then decide to hit 'cancel, it doesn't close the field; you are thrown further up the page but the 'add annotations' procedure remains open. Please note that this happens on both live and dmponline-test.

sjDCC commented 7 years ago

Have checked and I experience this too. It also lets you save with nothing entered in the box. The overview table then shows the template as having being customised although no guidance or suggested answers are saved or show up on the front end...

I've added an actual suggested answer and it's not showing on the front end either. I'm on a call now, but @dsisu could you do more testing adding content through annotations and checking they show up on front end please.

sjDCC commented 7 years ago

Ignore me. I missed the publishing step. All is working :)

Only thing is @dsisu's point that the box doesn't close when you cancel

sjDCC commented 7 years ago

Working fine now. Cancel closes the boxes. Closing out