DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 110 forks source link

Draft templates auto-generated on creation again? #377

Closed sjDCC closed 7 years ago

sjDCC commented 7 years ago

Every template I have looked at on DMPonline test has a draft showing in the history table e.g. draft-template

I thought we had decided to only create unpublished drafts when a published template was edited, not on creation?

xsrust commented 7 years ago

This is actually a result of the way the migration has been re-written.

In order to capture the most recent published version, and most recent edits to a template, two versions are created. The first is the most current published version. The draft is any versions/sections which have been added but not published. For convience, both are created for all templates.

If necissary, we can ammend this so the unpublished version does not get generated if no edits exist

vyruss commented 7 years ago

@xsrust I think that would be preferable (goal is: user should not notice a difference in their recent template history after migration)

sjDCC commented 7 years ago

Yes agree. Best to amend this so the unpublished version does not get generated if no edits exist

xsrust commented 7 years ago

solved by above commit, will only be testable once @vyruss re-migrates data to deploy to the server

sjDCC commented 7 years ago

Have checked for several different orgs and we no longer appear to be auto-creating a draft. Closing out