DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Fix formatting for "Public DMPs" PDF files #712

Closed stephaniesimms closed 6 years ago

stephaniesimms commented 6 years ago

related issue #436 (closed but referenced here just in case)

On the cover page:

screen shot 2018-01-05 at 9 06 22 am

On the plan pages that follow the cover page:

screen shot 2018-01-05 at 9 06 40 am

briri commented 6 years ago

@stephaniesimms I updated the cover page according to your instructions above. The layout of the abstract though looked strange since it contains HTML and did not display nicely (multiple lines, tables, lists, etc.). To solve this issue I bumped it down below the 'Project abstract:' label and indented it. I did the same with the longer 'Copyright information:' section as well to keep things consistent.

Let me know if that's ok or you'd like to take a different approach screen shot 2018-01-19 at 2 19 07 pm

briri commented 6 years ago

Updated the answers page as well (see screenshot) the 'Data Management Plan' text was the name of the phase for the template you were testing (we used that as a default during our data migration). I have updated it to show the 'project title' or 'project title - phase title' if the template has multiple phases (e.g. Horizon2020)

screen shot 2018-01-19 at 2 26 30 pm

stephaniesimms commented 6 years ago

I think your solution for the abstract looks good and agree re indenting the copyright statement too. I just want to test w/bullets, italics, other formatting to make sure it doesn't go wonky (or let me know if you already did so @briri ). the answers page looks good too.

two small changes:

stephaniesimms commented 6 years ago

content looks good @briri - i just have the same minor formatting requests as those for DMP Templates in #1003

briri commented 6 years ago

I'm not going to be able to insert line breaks within long sections of text @stephaniesimms since we just show whatever the user has entered in the answer/question/guidance through the tool.

stephaniesimms commented 6 years ago

i didn't want to or expect that we could mess w/formatting for user-provided text @briri - it's just hard to tell the root cause of various formatting issues (user or text editor/html weirdness). we can standardize the template and question formatting though i hope.

briri commented 6 years ago

Glad to hear it @stephaniesimms :) I'm able to format the PDFs as requested. I was able to do the same with the DOCX files to some extent. I cannot seem to manipulate the indentation of any of the text in DOCX unless we start using a different gem

stephaniesimms commented 6 years ago

overall PDF formatting is looking good @briri . after some more testing and comparison w/DMPTool I have more changes to request:

screen shot 2018-01-24 at 3 12 44 pm

screen shot 2018-01-24 at 3 12 59 pm

stephaniesimms commented 6 years ago

two small change requests @briri -

stephaniesimms commented 6 years ago

there's a funny line in the middle of the NSF EAGER PDF but that appears to be bad/old data. downloading newly created public plans looks good. closing issue.

sjDCC commented 6 years ago

I got these lines too in Jose's plan and the COMET one I've just published - I think it's the border for top and bottom of page floating elsewhere.

I created a completely new plan though and the lines were where they should be so assuming it's applying this to old data. Removing from board.