DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Revise Org Details page #726

Closed stephaniesimms closed 6 years ago

stephaniesimms commented 6 years ago

UX wireframe @rhu001 http://h90c3m.axshare.com/#g=1&p=dmp_organizational_profile__admin_view___tab_versi Related issue #729 to display up to three links in Org banner

Update the Org branding fields as displayed in wireframe:

For plan commenting functionality add tab section "Request Feedback" with:

Subject: [TOOL NAME] Your plan has been submitted for feedback

Message: Hello [USER NAME]. Your plan “[PLAN NAME]” has been submitted for feedback from an administrator at your organisation. If you have questions pertaining to this action, please contact us at [ORG CONTACT EMAIL].

briri commented 6 years ago

See #727 for Dev notes and the workflow for the Feedback process

briri commented 6 years ago

Updated details tab. Moved the org logo section to the top so that it appears above the URLs and contact email. It looked lonely when placed at the bottom.

Note that the 'Add an additional URL' link is not visible in the screenshot because there are already 3 URLs defined.

Updated the org branding bar at the top to use these new links. The bottom config info only appears for Super Admins, and the Shib entries in that section only appear when shibboleth discovery service is enabled (the DMPTool curated list of institutions allowed to login via Shibboleth).

screen shot 2017-10-25 at 11 47 24 am

briri commented 6 years ago

Added Request Feedback section. screen shot 2017-10-25 at 3 09 24 pm

@stephaniesimms and @sjDCC, The DMPTool uses the email info on this screen to allow the org to override an email that gets sent to the user who has clicked 'Request Feedback'.

From what I understand though we're only going to send an email to the Org admins (and org admin contact) when a user clicks 'Request Feedback' and another when the admin indicates that they are done providing feedback (that's 2 separate emails, so which one are we allowing them to override here?

Do we also need to send the plan's owner an email? I believe the DMPTool was doing this to allow Orgs to set user's expectations with regard to the turn-around time for feedback.

stephaniesimms commented 6 years ago

@briri - page looks great. re the email, the text entered here is sent to plan owners when they click the button on Share page to Request expert feedback. at the same time a separate email is sent to Org admins and admin contact email to notify them that a user has requested feedback. that second email is being added as part of issue #727

briri commented 6 years ago

ok thanks for the clarification @stephaniesimms

stephaniesimms commented 6 years ago

@briri - a few changes:

Subject: [TOOL NAME] Your plan has been submitted for feedback

Message: Hello [USER NAME]. Your plan “[PLAN NAME]” has been submitted for feedback from an administrator at your organisation. If you have questions pertaining to this action, please contact us at [ORG CONTACT EMAIL].

briri commented 6 years ago

default email content changed as part of #727. Still need to update the tooltip as described above

stephaniesimms commented 6 years ago

@briri - all working as expected w/minor exceptions related to the auto-email:

Subject: [TOOL NAME] Your plan has been submitted for feedback

Message: Hello [USER NAME]. Your plan “[PLAN NAME]” has been submitted for feedback from an administrator at your organisation. If you have questions pertaining to this action, please contact us at [ORG CONTACT EMAIL].

screen shot 2017-11-14 at 2 22 29 pm

sjDCC commented 6 years ago

Sample text looks good @stephaniesimms

I assume this is what we'll send out by default too if the org-admin doesn't specify their own text?

briri commented 6 years ago

I am going to use '%{user_name}' and '%{plan_name}' in the tooltip instead of '[USER NAME]' and '[PLAN NAME]'. The code will automatically convert those keywords to the correct values. Is that alright?

sjDCC commented 6 years ago

Sounds good to me

stephaniesimms commented 6 years ago

yes @briri - by all means use the correct values.

sjDCC commented 6 years ago

Tooltip looks good. It would be nice if people could easily copy/paste it but I guess this can't be achieved as it's a hover-over

Closing out

sjDCC commented 6 years ago

Re-opening as I just spotted a related issue on testing.

The email out to users is still showing html

p-tags

stephaniesimms commented 6 years ago

@briri - ditto on html in the email. moving back to in progress.

stephaniesimms commented 6 years ago

email formatting looks good now. closing issue.