DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
104 stars 110 forks source link

CSS refinements #746

Closed briri closed 6 years ago

briri commented 7 years ago

Now that the Bootstrap overrides are in place on roadmap-stg we should begin another round of review. @dsisu, @sjDCC and @stephaniesimms please take a look at the site now and record any refinements to color, fonts, borders, spacing, alignment, etc. in this ticket.

stephaniesimms commented 7 years ago

1- Guidance page - Actions menu cut off at bottom of table

screen shot 2017-10-18 at 12 35 42 pm

2- Guidance page - Actions menu cut off at bottom and side of table, need more space between table and footer

screen shot 2017-10-18 at 12 36 31 pm

3- Templates page - same problems with Actions menu and footer

screen shot 2017-10-18 at 12 37 37 pm

4-5 Templates page - Save, Cancel buttons obscured by footer when resizing page

screen shot 2017-10-19 at 10 59 21 am screen shot 2017-10-19 at 10 59 35 am

6 - Pop-up tooltips should be wider screen shot 2017-10-22 at 4 21 01 pm

7 - Remove filter box from My Dashboard tables, anywhere else it appears screen shot 2017-10-22 at 4 42 27 pm

8 - Fix layout on Write plan page so full text editor for Comments is visible screen shot 2017-11-14 at 3 39 33 pm

briri commented 7 years ago

Looks like btn-default and btn-primary have different top margin settings. They should be the same screen shot 2017-10-27 at 11 12 35 am

briri commented 7 years ago

This is happening in Chrome on my laptop. not sure if its happening in other browsers. I have not noticed it on my large iMac monitor. It looks like when the text in the footer is long and causes the navbar to wrap. This causes the footer to sit on top of the bottom portion of the page hiding the 'Save' button

screen shot 2017-10-27 at 2 57 02 pm

This should be easily reproducible by manually resizing your browser window

briri commented 6 years ago

Update colors of notice/alert messages to match those on the current DMPonline site.

briri commented 6 years ago

the error message on the forgot password page is not the correct color (any color) when you enter an email that is not in the system

bhavi commented 6 years ago

Wud it makes sense to either use btn-default or btn-primary across the app? We are overwriting the styling anyway.

briri commented 6 years ago

yeah we should use those two classes across the site.

jollopre commented 6 years ago

@bhavi for the refactor I made, I used btn-default since it is colourless

stephaniesimms commented 6 years ago

@bhavi - most things are looking good. some minor tweaks:

screen shot 2017-11-22 at 2 03 21 pm

stephaniesimms commented 6 years ago

@sjDCC I created a new issue to capture new requests and transferred your comments #867 - we can all continue adding to it for the next round of customizing bootstrap.

@bhavi after you make the minor changes I noted above we can close this one out.

stephaniesimms commented 6 years ago

the two changes noted above still haven't been made. @bhavi please:

screen shot 2017-11-22 at 2 03 21 pm

stephaniesimms commented 6 years ago

looks good on roadmap stage. closing issue.