Closed briri closed 6 years ago
We may want to adjust where the message display and to whom too. The main use cases I can think of for global notifications to be set by super admins are:
Downtime announcements would definitely want to display to everyone and be visible on the homepage prior to login. Alerts about new content and features though should perhaps only present to certain groups or once logged in. The example given above of 'Funder template 'X' has been updated. Please review your customizations.' would be most pertinent to display to org admins rather than all users.
We may also want to think about how they display. Do we have a panel that always shows and can't be clicked away / removed from view? If so what is the effect on mobile device screens and the extra scroll. Or do we have a more discrete notification alert / pin as in GitHub and Social Media sites that the user opens.
Thanks for revisiting @sjDCC. I agree that we would want to display:
w/regard to mobile display, the site isn't responsive in its current form so i wouldn't let that affect design decisions for now.
overall, i favor keeping it simple and implementing one kind of/approach to global notifications
Thanks Steph. New feature alerts aren't a priority for us currently either - was just trying to flesh out when this may be used and for what kind of things as the mock-up leaves it pretty open.
If we're really only talking about downtime announcements and new funder templates then perhaps we want them on the homepage rather than my dashboard? Downtime definitely wants to be public and possibly funder template news too, though I can also see the use of a specific message to alert admins either on My Dashboard or close to where they customise funder templates.
Let's see what the French use cases are too and design from there.
type
global (just this for now)alert
level i.e. urgent, info, etc for importance/colourtitle
: short title for the notification e.g. "Downtime: 3/12 08:00-05:00"text
: free text to be displayed upon click e.g. "On Friday 12 March from 8 to 5pm we will..."dismissable
/closeable
: notifications you are able to close (e.g. you can't close downtime alerts)created_at
timestamp for orderingexpires_at
timestamp to stop displaying itTitle | Timestamp | Seen |
---|---|---|
New templates out for testing! | 3/12/2018 08:35 | Mark as seen |
Downtime: 3/12 08:00-05:00 | 3/12/2018 07:10 | ✓ |
lets add a starts_at
datetime field as well to the table so that admins can create the notification before they want it to display to users.
I'd also like to see what @benjaminfaure and his team have done from the UI perspective. A separate notifications page is a good long term strategy but a simple message area at the top of the page may be a good lightweight solution at this point (especially if we're really just focused on global outage type notifications right now).
looking forward to seeing what @benjaminfaure have done! just to summarize the requirements discussion between me and @sjDCC above, we're looking for a simple message area for a narrow set of global notifications (maintenance downtime, funder template changes). messages could be displayed on the homepage or My Dashboard.
@stephaniesimms @briri agree, that's what I mean by "notification area" - i.e. where our alerts currently appear, where the "global" notifications will appear. The "notification page" is a separate page where one will also be able to see their "personal" notifications
ok thanks for clarifying @vyruss. there's nothing in the requirements for a personal notifications page so it sounds like we can focus on the global notifications.
If @Sudiukil is making good progress on the global notification, should we add a personal notifications page or should westop with the essential ?
Also question for the devs : Do you have any advice on how to initialize the Notification Type table ? Should we create a new rake task ?
@benjaminfaure yes a rake task would be a good approach for seeding the table. If you could also add them to the db/seeds.rb
file it would be appreciated.
we only need a global notifications page @benjaminfaure . no personal notifications. looking forward to the demo.
@benjaminfaure not at this stage, I just included it in the notes as it was part of the conversation
Quick question, how should we sort the notifications on the index page ? For now it's sorted by title, but I don't think it's the most natural sort order... what do you think ? Maybe by start date (with expiration date as second choice) ? Or simply by creation date (would require to add a column to the index though) ?
@Sudiukil yes, I think start date, then expiration date makes sense (if we can sort by two fields).
PR in review. moving this issue to the board so we can test the UI and include it in next release.
thoroughly tested and all appears to be working as expected except for bug issue #1494. closing this issue.
Create a page that allows Super Admins to create global system messages. UX wireframe @rhu001 http://h90c3m.axshare.com/#g=1&p=dmp_notification_announcement_feature
Example use cases would be 'Funder template 'X' has been updated. Please review your customizations.' or 'System maintenance scheduled for 11/15/2017', etc.
Need to create a new page (accessed via the Super Admin menu) that: