DMPRoadmap / roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
102 stars 109 forks source link

Global notifications #754

Closed briri closed 6 years ago

briri commented 6 years ago

Create a page that allows Super Admins to create global system messages. UX wireframe @rhu001 http://h90c3m.axshare.com/#g=1&p=dmp_notification_announcement_feature

Example use cases would be 'Funder template 'X' has been updated. Please review your customizations.' or 'System maintenance scheduled for 11/15/2017', etc.

Need to create a new page (accessed via the Super Admin menu) that:

sjDCC commented 6 years ago

We may want to adjust where the message display and to whom too. The main use cases I can think of for global notifications to be set by super admins are:

  1. downtime announcements
  2. new feature alerts
  3. new content e.g. funder templates

Downtime announcements would definitely want to display to everyone and be visible on the homepage prior to login. Alerts about new content and features though should perhaps only present to certain groups or once logged in. The example given above of 'Funder template 'X' has been updated. Please review your customizations.' would be most pertinent to display to org admins rather than all users.

We may also want to think about how they display. Do we have a panel that always shows and can't be clicked away / removed from view? If so what is the effect on mobile device screens and the extra scroll. Or do we have a more discrete notification alert / pin as in GitHub and Social Media sites that the user opens. picture1

stephaniesimms commented 6 years ago

Thanks for revisiting @sjDCC. I agree that we would want to display:

  1. downtime announcements on homepage, possibly also on My Dashboard
  2. new feature alerts we handle through other newsfeeds currently (e.g., blog) - it might be nice to display them somewhere prominently in the UI as well but this isn't a requirement for DMPTool
  3. changes that require users to take some action (e.g. funder template update) are the other main reason for global notifications. in this example, admins need to know about it so they can transfer customizations but users would also benefit from a notice about funder template updates. this is why we initially thought about global notifications having a central My Dashboard display. another way to handle notifications would be tucked into a nav bar as in your screenshot above, but i tend to ignore these. we could always test a prototype.

w/regard to mobile display, the site isn't responsive in its current form so i wouldn't let that affect design decisions for now.

overall, i favor keeping it simple and implementing one kind of/approach to global notifications

sjDCC commented 6 years ago

Thanks Steph. New feature alerts aren't a priority for us currently either - was just trying to flesh out when this may be used and for what kind of things as the mock-up leaves it pretty open.

If we're really only talking about downtime announcements and new funder templates then perhaps we want them on the homepage rather than my dashboard? Downtime definitely wants to be public and possibly funder template news too, though I can also see the use of a specific message to alert admins either on My Dashboard or close to where they customise funder templates.

Let's see what the French use cases are too and design from there.

vyruss commented 6 years ago

Notes from developer meeting of 6 Apr 18:

briri commented 6 years ago

lets add a starts_at datetime field as well to the table so that admins can create the notification before they want it to display to users.

I'd also like to see what @benjaminfaure and his team have done from the UI perspective. A separate notifications page is a good long term strategy but a simple message area at the top of the page may be a good lightweight solution at this point (especially if we're really just focused on global outage type notifications right now).

stephaniesimms commented 6 years ago

looking forward to seeing what @benjaminfaure have done! just to summarize the requirements discussion between me and @sjDCC above, we're looking for a simple message area for a narrow set of global notifications (maintenance downtime, funder template changes). messages could be displayed on the homepage or My Dashboard.

vyruss commented 6 years ago

@stephaniesimms @briri agree, that's what I mean by "notification area" - i.e. where our alerts currently appear, where the "global" notifications will appear. The "notification page" is a separate page where one will also be able to see their "personal" notifications

stephaniesimms commented 6 years ago

ok thanks for clarifying @vyruss. there's nothing in the requirements for a personal notifications page so it sounds like we can focus on the global notifications.

benjaminfaure commented 6 years ago

If @Sudiukil is making good progress on the global notification, should we add a personal notifications page or should westop with the essential ?

Also question for the devs : Do you have any advice on how to initialize the Notification Type table ? Should we create a new rake task ?

briri commented 6 years ago

@benjaminfaure yes a rake task would be a good approach for seeding the table. If you could also add them to the db/seeds.rb file it would be appreciated.

stephaniesimms commented 6 years ago

we only need a global notifications page @benjaminfaure . no personal notifications. looking forward to the demo.

vyruss commented 6 years ago

@benjaminfaure not at this stage, I just included it in the notes as it was part of the conversation

Sudiukil commented 6 years ago

Quick question, how should we sort the notifications on the index page ? For now it's sorted by title, but I don't think it's the most natural sort order... what do you think ? Maybe by start date (with expiration date as second choice) ? Or simply by creation date (would require to add a column to the index though) ?

vyruss commented 6 years ago

@Sudiukil yes, I think start date, then expiration date makes sense (if we can sort by two fields).

stephaniesimms commented 6 years ago

PR in review. moving this issue to the board so we can test the UI and include it in next release.

stephaniesimms commented 6 years ago

thoroughly tested and all appears to be working as expected except for bug issue #1494. closing this issue.