DMPbelgium / roadmap

5 stars 1 forks source link

Suggested feature: improved readability of downloaded document: phase title #28

Closed laurastandaert closed 2 years ago

laurastandaert commented 2 years ago

What version of the DMPRoadmap code are you running? (e.g. v2.2.0) v3.0.2

Expected behaviour: New line to indicate phase that was downloaded (or move to first line)

Actual behaviour: downloaded phase is separated from title only by hyphen; not readily visible for end users

Steps to reproduce: Download a plan; in particular one with a long title example image

laurastandaert commented 2 years ago

related: https://github.com/DMPRoadmap/roadmap/issues/2251#issuecomment-973964755

nicolasfranck commented 2 years ago

in config/initializers/ugent.rb overwrite as such:

require "plan_exports_controller"

class PlanExportsController

  def file_name
    "plan_#{@plan.id}_phase_#{@selected_phase.id}"
  end

end

and maybe include updated_at in some format?

@laurastandaert this will result in something like plan_123_phase_45.pdf. Note sure if that is helpful but at least it is less annoying..

Note to self: see (local) branch fix_issue_28

nicolasfranck commented 2 years ago

Is actually about the title in the export which is now " - <phase title>" -> better not put phase title on the next line?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/nicolasfranck"><img src="https://avatars.githubusercontent.com/u/494636?v=4" />nicolasfranck</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>@laurastandaert how would you like to change this title on the pdf? If I put the phase title on a separate line, in itself it is not clear that a phase is indicated, as the line is just too close to the upper title. Making it smaller, and a lighter tone would help..</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/nicolasfranck"><img src="https://avatars.githubusercontent.com/u/494636?v=4" />nicolasfranck</a> commented <strong> 2 years ago</strong> </div> <div class="markdown-body"> <p>see <a href="https://github.com/DMPbelgium/roadmap/commit/9150467c421834b4c5c637bd6ed698e8253ba961">https://github.com/DMPbelgium/roadmap/commit/9150467c421834b4c5c637bd6ed698e8253ba961</a></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>