duplicate org name in guidance choices

[StCyr]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

4.1.0

Expected behaviour:

In the screenshot in the "actual behaviour" chapter below, Belnet should appear only once

Actual behaviour:

duplicate org name in guidance choices.

In the screenshot hereunder, Belnet appears twice:

Possible fix

change:

<% choices.each do |org, groups| %>

to

<% choices.uniq.each do |org, groups| %>

in app/views/plans/_guidance_choices.html.erb

[nicolasfranck]

@StCyr better to update @important_ggs in app/views/plans_controller.rb#show.

What happens: in the "short" view of available guidance groups it shows the following:

• guidance groups belonging to the organization of the logged in user
• guidance groups belonging to the "default" organizations

And in this case "Belnet" is both a default organization, and you happen to be attached to organization Belnet.

BTW: in the full view (via the modal) it is all fine.

[StCyr]

@TheLisaVL and I are wondering if it wouldn't be better to set "DCC" as default organisation...

[nicolasfranck]

Forgot about the rationale behind the default organization. In the code I only see references to Org.default_orgs in code that handle guidances and guidance groups. So maybe the default organization is being misused?

@laurastandaert @mm449 ?

[StCyr]

should be fixed in version 4.2.0