search

DMPbelgium / roadmap

5 stars 1 forks source link

Lingering references in mails to the 'write plan' tab which no longer exists #90

Open TheLisaVL opened 8 months ago

TheLisaVL commented 8 months ago

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

Expected behaviour: References to the 'write plan' tab are gone since we no longer use it.

Actual behaviour: Mail templates still contain references to the 'write plan' tab, even though it no longer exists. Example: Hello XXX XXX has finished providing feedback on the plan "XXX". Comments can be found in the 'Write plan' tab on the right side of the page (Guidance/Comments). All the best The DMPonline.be team You may change your notification preferences on your profile page. Please do not reply to this email. If you have any questions or need help, please contact us at servicedesk@belnet.be or visit https://dmponline.be/contact-us

Steps to reproduce: Provide feedback on a plan. References might also still exist in other templates, to be investigated.

TheLisaVL commented 7 months ago

Additional feedback on the mail templates: Every mail sent for plan create/invite/feedback should have a link to that plan.

StCyr commented 2 months ago

Hello @TheLisaVL,

References to the 'write plan' tab are gone since we no longer use it.

What do you mean by "we no longer use it"? Is it a dmponline.be specific configuration (in which case we should update it) or has it changed upstream (in which case they should update it)?

StCyr commented 2 months ago

problem reported upstream: https://github.com/DMPRoadmap/roadmap/issues/3404

TheLisaVL commented 2 months ago

@StCyr Write plan is the phase name of a plan's first phase, however we changed it so now it displays the name of the phase instead of 'Write plan'