search

DMPbelgium / roadmap

5 stars 1 forks source link

error message when orcid email is not visible is too generic #94

Open StCyr opened 7 months ago

StCyr commented 7 months ago

Since the implementation of:

a8b25acc1 (******* 2023-05-22 16:13:43 +0200 1298)       # User is not logged in
3f30560be (******* 2023-11-20 11:30:12 +0100 1299)       email = auth["info"]["email"].downcase

Users receive an error message that's too generic when their orcid email is not visible (extract from a support request from one of our customer):

image

Is it possible to set a more meaningfull message for this case?

nicolasfranck commented 7 months ago

There is already a specific event for that here. But I guess the code never reaches that point due to a nil pointer exception (auth["info"]["email"] is `nil).

TODO

StCyr commented 7 months ago

should still be tested and pushed in prod

StCyr commented 7 months ago

patch doesn't solve the issue. Best is probably to move the "if email.present?" test closer to line 1299

nicolasfranck commented 7 months ago

It would also help to have some logs available, because we are kind of reading in the dark here, trying to figure what could be the cause.

StCyr commented 6 months ago

https://test.dmponline.be patched.

can be tested over there